Frequently Given Advice
When pairing or doing code reviews, I often find myself repeating the same pieces of advice.
Some of these points have background or nuance that’s hard to convey in a quick comment, which can make the feedback feel incomplete.
This collection captures those recurring bits of advice in one place - with the context they deserve.
-
When no strong semantic or conventional ordering exists, prefer lexicographical order.
This provides a consistent, discoverable rule that reduces ambiguity for contributors.
-
Use American spellings to increase consistency with platform frameworks and reduce cognitive dissonance when reading code.
-
Be cautious about using default arguments in data types or constructors - they can reduce safety, clarity, and discoverability in your code.